search

Open-RIO / ToastAPI

An Open Source robot API for FRC - The Best thing since Sliced Bread
MIT License
71 stars 12 forks source link

Fixed line endings so gradlew executes on Unix #3

Closed arilotter closed 9 years ago

arilotter commented 9 years ago

A CRLF after the shebang prevent scripts from working under Unix for some reason. Replaced all LFs with CRLFs (in this file.) Would it be a good idea to just change the initial CRLF to LF or is it a bad idea to mix line endings??

JaciBrunning commented 9 years ago

Yea, unfortunately when I generated the Gradle files it was on windows. Since the PR is closed, I'll fix the line endings and make a commit soon. The unix_gradle.rb script in the root of the project should be able to fix that CR issue on all the gradle files, given it's run on Unix. Thanks for keeping an eye out!

arilotter commented 9 years ago

Closed my PR because I wasn't sure how to go about merging line-endings. Thanks for fixing it :)

JaciBrunning commented 9 years ago

Merging line endings on the gradlew file should work fine. The line endings on the Toast gradlew file seem to be fine, considering Travis is building (linux). If you're grabbing from the releases page however, the line endings issue is in release/gradlew. I think the issue is that when I Zip and Build the release archive with Gradle, the line endings get converted. I'll confirm that on a linux and mac box soon, and open an Issue if it's true.