Open-Systems-Pharmacology / OSPSuite.ParameterIdentification

R package for parameter identification for OSPS models
http://www.open-systems-pharmacology.org/OSPSuite.ParameterIdentification/
GNU General Public License v2.0
3 stars 2 forks source link

Remove scaling option from PIConfiguration #119

Closed rengelke closed 4 months ago

rengelke commented 4 months ago

scaling should be only configured and validated in PIOutputMapping using ScalingOptions. Removing scaling option from PIConfiguration$objectiveFunctionOptions

scaling Impact is already documented in error-calculation vignette

codecov-commenter commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 84.59%. Comparing base (6250c87) to head (2a9c949).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #119 +/- ## ========================================== - Coverage 84.61% 84.59% -0.03% ========================================== Files 10 10 Lines 754 753 -1 ========================================== - Hits 638 637 -1 Misses 116 116 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.