search

Open-Systems-Pharmacology / OSPSuite.SimModel

Calculation engine for models built with PK-Sim® or MoBi®
Other
4 stars 3 forks source link

134 jacobian calculation of the product formula wrong #135

Closed Yuri05 closed 2 years ago

Yuri05 commented 2 years ago

@abdelr With this change, I get the same old and new diagonal jacobian values in your example (https://github.com/Open-Systems-Pharmacology/OSPSuite.SimModel/pull/133#issuecomment-1042652766)

Yuri05 commented 2 years ago

we definitely miss tests in this area. Not quite easy though with the current test approach. When moved from C++/CLI to PInvoke, all such tests were removed, because not easy to realize. Need to think how this can be improved. https://github.com/Open-Systems-Pharmacology/OSPSuite.SimModel/issues/136