search

OpenAMP / openamp-system-reference

End-to-end system reference material showcasing all the different aspects of OpenAMP, on multiple vendor platforms.
Other
16 stars 15 forks source link

Move apps dir from the open-amp repository #19

Closed kernelchuk closed 4 months ago

kernelchuk commented 1 year ago

My first attempt to move the apps based on our discussions about libmetal examples. Please, see: https://github.com/OpenAMP/libmetal/pull/231.

arnopo commented 1 year ago

@wmamills, @edmooring, @tnmysh, @glneo:

This PR simply moves the application folder from the library, which I believe is a step in the right direction.

As we have rejected https://github.com/OpenAMP/openamp-system-reference/pull/15, I want first to confirm that everyone is okay with this PR.

The middle -term objectives (from my point of view) is to:

Is everyone is Ok with that plan?

tnmysh commented 1 year ago

@wmamills, @edmooring, @tnmysh, @glneo:

This PR simply moves the application folder from the library, which I believe is a step in the right direction.

As we have rejected #15, I want first to confirm that everyone is okay with this PR.

The middle -term objectives (from my point of view) is to:

  • First, clean up libraries by removing applications and tests (which is the objective of this PR).
  • Second, enhance the baremetal/FreeRtos applications to support non-AMD platforms.

Is everyone is Ok with that plan?

Thanks @arnopo, I am okay with this plan.

kernelchuk commented 1 year ago

Hi @arnopo, @wmamills, @edmooring, @glneo:

I have been up-streaming AMD’s internal commits to achieve the “upstream first” status, i.e., our internal forks have minimum divergence from the GitHub. Our largest delta is in the examples, which are frozen in OpenAMP (see https://github.com/OpenAMP/libmetal/pull/23) pending the move to this repo.

@arnopo posted two objectives. The first one is clear and easy to understand. I think the second objective should be a community effort, i.e.: the example code grandfathered in the first step will have to adopt a new common/platform-specific framework. This framework is yet to be defined.

My management approves my work to:

  1. Move the examples:
  2. Convert them to the new common framework when it’s defined by the community.

Can we, please, clarify if the second objective (support non-AMD platforms) is or is-not a precondition to the move?

arnopo commented 1 year ago

Hi @arnopo, @wmamills, @edmooring, @glneo:

I have been up-streaming AMD’s internal commits to achieve the “upstream first” status, i.e., our internal forks have minimum divergence from the GitHub. Our largest delta is in the examples, which are frozen in OpenAMP (see OpenAMP/libmetal#23) pending the move to this repo.

@arnopo posted two objectives. The first one is clear and easy to understand. I think the second objective should be a community effort, i.e.: the example code grandfathered in the first step will have to adopt a new common/platform-specific framework. This framework is yet to be defined.

My management approves my work to:

  1. Move the examples:

  2. Convert them to the new common framework when it’s defined by the community.

Can we, please, clarify if the second objective (support non-AMD platforms) is or is-not a precondition to the move?

Sorry for the delay, we are still discussing on the way we do do it. Come back to you ASAP

wmamills commented 5 months ago

@tnmysh I presume your PR# 44 makes this redundant. If so please close this one.

wmamills commented 4 months ago

PR #44 replaces this PR