OpenArchive / Save-app-ios

Secure Mobile Media Preservation
https://open-archive.org/
GNU General Public License v3.0
10 stars 3 forks source link

New Hamburger implementation for servers #283

Closed vanichitkara closed 6 months ago

vanichitkara commented 6 months ago

Implementation of a new hamburger menu for the servers.

The new design: 1 4c Home - Media - Private Server signed in 1 4d Home - Menu

tladesignz commented 6 months ago

So, nothing really changing here, but two things?

  1. Change "Add Another Account" text to "Add Server"?

Ok, that's minor and seems a good idea to align concepts better.

  1. Change the header title from the currently displaying selected server to the generic title "Servers"?

Weeeelll. Either I don't get something here, or you seemed to miss the fact, that the header in the current form is the header for the below listed folders on the selected server.

And at the same time, it is the reference reminder of what server is actually selected.

Especially when collapsed.

Don't get me wrong - I'm all for changing this, as currently it's like the old Windows problem of pressing "Start" to shut down the computer, which is ugly. But this seems not the solution, yet.

Please either provide some more explanation of how you actually want this to work, in case I didn't grasp some ideas from that single picture, or rethink and improve, in case I interpreted this right.

Thanks!

tladesignz commented 6 months ago

Ah, ok. Now I get it.

For the future: Please don't just edit the issue. I won't get a notification about it. If instead of commenting, an edit of the original issue seems more appropriate, please also leave a short comment that you did that, so I will be informed, that something changed.

Thanks!

tladesignz commented 6 months ago

Will be contained in version 3.3.0, build 115!

foundscapes commented 6 months ago

@vanichitkara please test, it's working great for me!

vanichitkara commented 6 months ago

This is working great for me too! OS: iOS 16.7.7 Device: iPhone 8 Plus Version: 3.3.0, build 117