OpenBazaar / multiwallet

API based multi-cryptocurrency wallet
MIT License
75 stars 41 forks source link

Fix bug generating new addresses when lookahead window is exhausted #98

Closed cpacia closed 5 years ago

cpacia commented 5 years ago

The new address function uses the last unused key to figure out where to extend the keychain. But if there isn't a last unused key then we have trouble.

This commit extends the lookahead window first so there always is unused keys.

coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 523


Changes Missing Coverage Covered Lines Changed/Added Lines %
keys/keys.go 8 16 50.0%
litecoin/wallet.go 10 19 52.63%
bitcoin/wallet.go 5 21 23.81%
zcash/wallet.go 6 23 26.09%
<!-- Total: 29 79 36.71% -->
Totals Coverage Status
Change from base Build 508: -0.3%
Covered Lines: 2839
Relevant Lines: 5275

💛 - Coveralls
cpacia commented 5 years ago

For some reason I was thinking it included the package name not the function.