search

OpenBazaar / openbazaar-go

OpenBazaar 2.0 Server Daemon in Go
MIT License
994 stars 283 forks source link

'Dial' is deprecated #1312

Open gubatron opened 5 years ago

gubatron commented 5 years ago

I get warnings to replace deprecated Dial for the newer DialContext on:

This deprecation warning might be related to the following 2 reported issues as I briefly read the recommendation has something to do with DNS resolver pass-through.

Investigate long context of IPFS dials ending with "Routing not found"

https://github.com/OpenBazaar/openbazaar-go/issues/1294

name resolution failures running openbazaard in docker

https://github.com/OpenBazaar/openbazaar-go/issues/1023

If nobody knows how to do this refactor quickly I'll try to make this my next PR.

placer14 commented 5 years ago

Hey @gubatron. We're merging multiwallet into master this week so you might want to wait until the dust settled to avoid a major refactor. When this PR is closed, it should be safe to move forward with your plan. 🍻

gubatron commented 5 years ago

Understood! Thanks for the heads up.