integration test failed locally

OpenCerts / legacy-templates

Apache License 2.0

0 stars 25 forks source link

integration test failed locally #15

Closed mmysgp closed 5 years ago

mmysgp commented 5 years ago

npm run integration:headless

Integration test failed when running locally. All NP's templates passed the integration test in Apr when we did the last modification in opencerts-website. Now using legacy template, some succeeded, some failed, even through we did not change any thing.

Another error encountered:

Even GovTech's template also failed.

How do we know whether the code is good to submit a pull request? Please try out the integration test locally and let us know how to proceed.

Thanks.

rjchow commented 5 years ago

will look at this thanks

rjchow commented 5 years ago

I'm not having trouble executing the integration tests locally or on the travis environment, so lets troubleshoot your environment

clear out your node_modules folder and run npm install
have to run npm run start inside legacy-templates before running integration tests

mmysgp commented 5 years ago

tried to reinstall legacy template on my PC. All NP's templates passed the integration test. But other institute's templates still got error. Is it related to the PC specs?

rjchow commented 5 years ago

possible but I suspect quite unlikely as the travis environments are quite low spec are the failures consistent between runs?

mmysgp commented 5 years ago

I tried on Mac, no error. But on my PC (Windows 10), the error is consistent between runs.

Btw, may I know the URL of the legacy template (Both Testing and PRD) so that we can use it to develop a preview function in our system?

rjchow commented 5 years ago

hmm maybe its a unix thing I'll have a look at that when I have access to a windows environment legacy template renderer is hosted at https://legacy.opencerts.io/ , there's no testing preview as there is no verification of the certificate done by the renderer (i.e it works for both testing and prod certs)

mmysgp commented 5 years ago

The two new templates also failed integration test in travis.

However, they can be rendered successfully locally.

Please check the Pull Request #22 for details.

mmysgp commented 5 years ago

Solved the integration test issue for two new NP templates after using signed JSON files. However, still encountered error for other institution's templates when running locally.

rjchow commented 5 years ago

thanks wu yong