OpenChemistry / openchemistry

Supermodule containing submodules and external project to build all components
http://openchemistry.org/
BSD 3-Clause "New" or "Revised" License
80 stars 60 forks source link

Git submodule and repo name for `avogadrogenerators`/`avogenerators` don't match #137

Open matterhorn103 opened 3 weeks ago

matterhorn103 commented 3 weeks ago

This just adds confusion and adds a little bit of extra friction to getting the source code ready to build on a machine. Can we please synchronize the two?

Easiest solution is of course to change the submodule's name rather than the name of the repo i.e. standardize on avogenerators everywhere; that way all https and .git links to the repo remain valid. With that approach the only changes required in the code are in .gitmodules and in avogadrolibs/avogadro/qtplugins/quantuminput/CMakeLists.txt.

I tried doing that in my fork but it didn't work for whatever reason, so would appreciate it if someone else who knows what they're doing could make the change.