Closed bmamlin closed 1 month ago
CIEL v2024-10-04 validated and released on Staging. No failures on import.
Production import appeared to stall at 285956/290272 (98.5%). @snyaggarwal reported it had completed. Import reported 40 failures (the same we've had where some Spanish non-preferred synonyms match other concept FSNs, since #1921 has not yet been deployed to production). On validation, there was one discrepancy: Gloves, latex (169370) was missing. Looking at the report, this concept was in the list of failures with the error message: "Concept fully specified name must be unique for same source and locale: Guantes de goma de látex (locale: es, preferred: yes)".
I tried manually importing this one concept, expecting it to fail again and I'd need to manually delete the conflicting synonym to get it in... but I was surprised that the single concept import succeeded. Why would it fail during bulk import and then succeed when imported by itself? Maybe concept validation isn't performed during a manual import of text (instead of a file)? That doesn't seem likely. When I look for other concepts with "Guantes" in their names, I can't find one. So, maybe it was a bogus validation failure during the initial bulk import? Here's the entry from the report:
{
"retired": false,
"datatype": "N/A",
"type": "Concept",
"concept_class": "Misc",
"source": "CIEL",
"extras": {},
"names": [
{
"locale": "en",
"external_id": "bd51462c-d51d-4959-a085-b8651e93bfd0",
"locale_preferred": true,
"name": "Gloves, latex",
"name_type": "FULLY_SPECIFIED"
},
{
"locale": "es",
"external_id": "87f3dabc-1473-41e6-8e78-4f5be5b09a65",
"locale_preferred": false,
"name": "Guantes de látex de goma",
"name_type": ""
},
{
"locale": "es",
"external_id": "60831581-d96d-4385-8c82-701721d6ffc2",
"locale_preferred": true,
"name": "Guantes de goma de látex",
"name_type": "FULLY_SPECIFIED"
}
],
"owner": "CIEL",
"owner_type": "Organization",
"external_id": "1d8ff472-7758-410f-aef6-51d8aaecff1c",
"id": "169370",
"descriptions": [],
"errors": {
"names": [
"Concept fully specified name must be unique for same source and locale: Guantes de goma de látex (locale: es, preferred: yes)"
]
}
}
Strange. It doesn't make sense to me. In any case, now that 169370 exists on production, I've triggered a new export to validate again. Hopefully #1921 will make it to production, soon. 🙂
CIEL v2024-10-04 validated and released on staging and production.
@snyaggarwal deployed #1921 to production, so I scanned the 40 resources that failed to update for differences in names between staging & production (n=17). These and now updated in HEAD on Production.
Re-opening issue, since @askanter wanted to get the 17 updated concepts on production included within the CIEL v2024-10-04. So, we are planning to delete the version on production and then re-release.
CIEL v2024-10-04 re-released on production after #1921 deployed and previously blocked concepts updated.
Staging
Production