search

OpenConext / OpenConext-engineblock

OpenConext SAML 2.0 IdP/SP Gateway
14 stars 22 forks source link

Update makeRelease.sh to build assets #1546

Closed phavekes closed 2 days ago

phavekes commented 2 days ago

This issue is imported from pivotal - Originaly created at Apr 3, 2019 by bstrooband

MakeRelease should also build the assets so this is always done before making a release. This to make sure all the required assets are up-to-date.

Also we shouldn\'t have to worry about merge conflicts with the minified assets.

phavekes commented 2 days ago 
@michielkodde we have discussed thie earlier on IRL, I\'ve created an issue so we could fix this. (bstrooband - Apr 3, 2019)
phavekes commented 2 days ago

https://github.com/OpenConext/OpenConext-engineblock/pull/666 (bstrooband - Apr 5, 2019)

phavekes commented 2 days ago 
Merge the PR back to master.

@thijskh I assumed removing application.min.js from VCS wasn\'t an issue. If it is I\'ll create a new PR. (bstrooband - Apr 8, 2019)

phavekes commented 2 days ago

Discussed the question above and this won\'t be a problem. (bstrooband - Apr 8, 2019)

phavekes commented 2 days ago

Removed all assets in: https://github.com/OpenConext/OpenConext-engineblock/pull/667 (bstrooband - Apr 9, 2019)

phavekes commented 2 days ago

It has broken our branch install (which you could argue itself is broken). I\'ve proposed a pr to work around the issue for now. (Thijs Kinkhorst - Jun 19, 2019)