search

OpenDataServices / flatten-tool

Tools for generating CSV and other flat versions of the structured data
http://flatten-tool.readthedocs.io/en/latest/
MIT License
105 stars 15 forks source link

Some typos #459

Closed fchapoton closed 2 months ago

fchapoton commented 3 months ago

and a few minor code details in the 3rd commit

odscjames commented 2 months ago

Thank you! Can I ask how you decided we don't need to catch IOError - was there some tool that was used to detect this?

jpmckinney commented 2 months ago

In Python 3.3+, IOError is an alias of OSError https://docs.python.org/3/library/exceptions.html#OSError.filename2 https://peps.python.org/pep-3151/#confusing-set-of-os-related-exceptions

odscjames commented 2 months ago

Ah, thank you! I will sort this PR for merging after another one has gone in.

fchapoton commented 2 months ago

I am using the tool ruff, which can check many things.

Here : https://docs.astral.sh/ruff/rules/os-error-alias/

odscjames commented 2 months ago

Thank you! Merged in.