OpenDataServices / sphinxcontrib-opendataservices

Sphinx directives maintained by Open Data Services
MIT License
0 stars 0 forks source link

Move all of our Sphinx directives into this repository, #1

Closed Bjwebb closed 6 years ago

Bjwebb commented 6 years ago

and then include this as a sphinx extension everywhere that we use them.

Bjwebb commented 6 years ago

Places we have copies of our Sphinx directives:

Bjwebb commented 6 years ago

I propose we move to this repository:

Leave in ocds_sphinx_directives, because they're very specific to the way OCDS does extensions, but we should add a link to the repository in our docs:

Leave in openreferral specification conf.py, because its specific to JSON Schema table, which we're not likely to use elsewhere (and may move away from in the openreferral docs). We should add a mention to the docs though.

Bjwebb commented 6 years ago

Handling duplicates:

Appear only once, so we can use that copy

JSONInclude

Differences:

I think the best way to combine these is to start with the ppps version, change the formatting of that so it passes flake8 tests*, and then add the extra container node as in https://github.com/open-contracting/standard/commit/520afec26ad3afc7164283df8bfe1af78c6e695d.

* and also add flake8 as a Travis test.

JSONSchemaDirective and JSONSchemaFieldsDirective

These are very deliberate extensions of sphinxcontrib.jsonschema.JSONSchemaDirective, which initially I won't merge, but instead rename to more clearly differentiate them. These could possibly stay in their separate repositories, but I think by bringing them together it gives a better overview of what's possible next time someone needs to do something similar.

Bjwebb commented 6 years ago

Still to move:

Bjwebb commented 6 years ago

I've now made PRs to remove the code from the original repos: