search

OpenDriveLab / TCP

[NeurIPS 2022] Trajectory-guided Control Prediction for End-to-end Autonomous Driving: A Simple yet Strong Baseline.
Apache License 2.0
309 stars 40 forks source link

X and Y coordinate switched during packing data #33

Closed shuishida closed 1 year ago

shuishida commented 1 year ago

Hello, I was going through the data generation pipeline and noticed that the x and y coordinates are switched around in the data packing stage.

https://github.com/OpenPerceptionX/TCP/blob/ddcbc046b9f53008d35143c2093cb88bcaa80a76/tools/gen_data.py#L63-L64

Is this a typo, or could you provide me with some rational for why this is necessary please? Thank you!

shuishida commented 1 year ago

Ah I see that Carla uses the left-hand coordinate system and you are using the right-hand. It's easy to miss this swapping happening in the code though.