search

OpenDroneMap / ODM

A command line toolkit to generate maps, point clouds, 3D models and DEMs from drone, balloon or kite images. 📷
https://opendronemap.org
GNU Affero General Public License v3.0
4.92k stars 1.11k forks source link

geo.txt should accept yaw/pitch/roll values, not omega/phi/kappa #1473

Closed pierotofy closed 2 years ago

pierotofy commented 2 years ago

We currently set omega/phi/kappa values when reading from geo.txt files, but that's incorrect. We should set ypr angles and convert them for end users.

originlake commented 2 years ago

@pierotofy I'm working on #1415(finally get a chance to do it), figure I could add this as well. One problem is that will the ypr value in geo.txt take the camera make into consideration? As the ypr is treated differently in different make. If not need to consider this, call compute_opk after updating the geo entry should do the work.

https://github.com/OpenDroneMap/ODM/blob/157a2eb90a652f33fa8c91f4c0bb6c06ecb20388/opendm/photo.py#L426-L431

pierotofy commented 2 years ago

If not need to consider this, call compute_opk after updating the geo entry should do the work.

Yep! :+1:

pierotofy commented 2 years ago

Thanks for looking into this!