search

OpenDroneMap / ODM

A command line toolkit to generate maps, point clouds, 3D models and DEMs from drone, balloon or kite images. 📷
https://opendronemap.org
GNU Affero General Public License v3.0
4.92k stars 1.11k forks source link

INFO message for camera make/model/readout #1486

Closed Saijin-Naib closed 2 years ago

Saijin-Naib commented 2 years ago

This currently prints once per image in the Task so it gets noisy on the console. image I could use some help cleaning this up, if possible.

pierotofy commented 2 years ago

There; how's this one? https://github.com/OpenDroneMap/ODM/pull/1486/commits/4a9ca4c28332f93c8742dc89067864fa742449ed

Saijin-Naib commented 2 years ago

Beautiful, thank you so much! I was really struggling, haha.

The only other thing I can think of at this juncture that I don't know how to handle would be mixed-camera Tasks and ensuring that each camera is represented once by the appropriate WARN/INFO message.

So for instance if I had a Task that had TeraCube, GoPro, and Fuji data, I'd expect to see two INFO messages (TeraCube and GoPro) and one WARN (Fuji).

Does your fix address that mixed-camera usecase?

pierotofy commented 2 years ago

Does your fix address that mixed-camera usecase?

It does!

Saijin-Naib commented 2 years ago

I'm totally happy with this! If you're happy (and the CI/CD is happy) can we press merge?