OpenESignForms / openesignforms

Open eSignForms is the first open source SaaS web contracting platform
https://open.esignforms.com
107 stars 50 forks source link

Empty AND or OR condition that is negated results in a failed condition check #121

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Create custom logic rule.
2. Add a condition to any action.
3. Negate the topmost AND condition.
4. Remove the condition in step 2 so the NOT AND now has no subconditions.
5. Run a test and note that the NOT AND (which is not shown when not 
subconditions exist) will fail even though there are no subconditions, and the 
activity log shows: Condition: (with nothing following the colon).

What is the expected output? What do you see instead?
When a compound condition has no subconditions, disregard the negate setup, 
and/or ensure that the activity log condition is "NOT".

Original issue reported on code.google.com by yoz...@gmail.com on 25 Feb 2014 at 4:37

GoogleCodeExporter commented 9 years ago
Fixed in 14.4.12 release.

Changed CompoundCondition to output helpful text if there are subconditions 
(normally there should be at least one Condition in an AND or OR condition).  
This will also show the "NOT" prefix if it's negated.

Also, changed Action so that the hasCondition() will return false for 
CompoundConditions that have no subconditions (if no subconditions on the top 
level AND/OR condition) so that we just assume that this setup has no actual 
conditions to check.

Original comment by yoz...@gmail.com on 21 Mar 2014 at 7:05