search

OpenElements / hedera-solo-action

A GitHub Action for setting up a Hedera Solo network
Apache License 2.0
0 stars 3 forks source link

Update action.yml to handle the Hedera version #7

Closed Atharva1723 closed 4 days ago

Atharva1723 commented 1 week ago

Fixes issue #4 Added Optional Input Parameter:

  1. Introduced hederaVersion as an optional input parameter in the action's metadata.
  2. The default value for this parameter is set to the current Mainnet version (v0.52.2), ensuring compatibility with the latest release.
hendrikebbers commented 1 week ago

issue for the PR https://github.com/OpenElements/hedera-solo-action/issues/4

hendrikebbers commented 1 week ago

@Atharva1723 the definition of the param looks good. But it need to be used in the script. Otherwise it has no effect.

hendrikebbers commented 1 week ago

this line need to be refactored: solo init -i node0 -t v0.51.5 -n solo-test --key-format pem --profile local

Atharva1723 commented 6 days ago

this line need to be refactored: solo init -i node0 -t v0.51.5 -n solo-test --key-format pem --profile local

ok

hendrikebbers commented 5 days ago

@Atharva1723 looks good. Can you pls add the parameter to the readme.md with a short description. Once that is done I will merge the PR

Atharva1723 commented 4 days ago

Added please check