search

OpenEnergyPlatform / data-preprocessing

Repository for data formatting, import of data, data and metadata review, and data curation.
GNU Affero General Public License v3.0
10 stars 7 forks source link

review/open_MODEX base scenario datapackage #73

Open jh-RLI opened 3 years ago

jh-RLI commented 3 years ago

Closing #71

chrwm commented 2 years ago

@jh-RLI

chrwm commented 2 years ago

Can this be merged?

jh-RLI commented 2 years ago

The tables are still in the model draft schema. The problem is that moving them would lead to the oedatamodel api and dashboard no longer working. Adjustments would have to be made there. A solution for the moment would be to move the tables into the schema scenario and to keep the tables in the model draft for the time being. In addition, issues should then be created in the repos of the oedatamodel_api and dashboard.

I have not done the moving of tables via the API yet and do not know the function. @Ludee would have to provide some hint on how to do it.

Ludee commented 2 years ago

I have this on my list now. The table names are not following the OEP naming conventions and there are some minor issues with the metadata. I suggest to create a copy of the tables and and include all corrections and move. Then adjust the API to new ones and delete the old in model_draft!?

jh-RLI commented 2 years ago

good catch! I overlooked the upper case words in the table names 👍