search

OpenEnergyPlatform / data-preprocessing

Repository for data formatting, import of data, data and metadata review, and data curation.
GNU Affero General Public License v3.0
10 stars 7 forks source link

Review/modex consortium #95

Closed chrwm closed 2 years ago

chrwm commented 2 years ago

Closes https://github.com/OpenEnergyPlatform/data-preprocessing/issues/88

Cheery-picked grouped open_MODEX sources from https://github.com/OpenEnergyPlatform/data-preprocessing/pull/73

Should have been added the this PR https://github.com/OpenEnergyPlatform/data-preprocessing/pull/87

jh-RLI commented 2 years ago

OH just noticed that GitHub showed these files to me, but they actually don't exist in the folder ?! I'm experiencing some issues with GitHub in the previous days. @chrwm can you check if the files still exists? Otherwise, I approve this PR.

chrwm commented 2 years ago

Hi @jh-RLI, thanks for the review. The csv files should not be part of the pull request, I deleted them (which is part of the PR). The only thing missing in the metadata strings is the id field. I'll create the empty tables in the Schema: reference then and insert the id's into the metadata to complete the process.

chrwm commented 2 years ago

Alright, I created all tables in model_draft and attached the correct metadata (incl. id). If @jh-RLI don't have more issue, I'll merge the pull request tomorrow and someone with rights can move the tables from model_draft to the reference schema.

Ludee commented 2 years ago

The PR created the files in the wrong folder containing a space. I fixed it but added it to #71. Tables are moved now!