`B7` and `E10` are not inferred as subclasses of `blended liquid fuel`

l-emele commented 10 months ago

Description of the issue

In issue #1504 / PR #1723 we introduced:

blended liquid fuel: A blended liquid fuel is a liquid combustion fuel that contains a liquid fossil fuel and a liquid renewable fuel or a liquid biofuel.
B7: B7 is a diesel fuel that consists of fossil diesel fuel and up to 7 % biodiesel.
E10: E10 is a gasoline fuel that consists of (fossil) gasoline and up to 10 % ethanol.

Axioms:

Class: 'blended liquid fuel'
    EquivalentTo:
        'liquid combustion fuel'
         and ('has part' some 'liquid fossil fuel')
         and ('has part' some 
           ('liquid biofuel' or 'liquid renewable fuel'))

Class: B7
    SubClassOf:
        'diesel fuel'
        ('has part' some biodiesel)
         and ('has part' some 'fossil diesel fuel')

Class: E10
    SubClassOf:
        'gasoline fuel'
        ('has part' some gasoline)
         and ('has part' some bioethanol)

It was intended that B10 and E10 will be (inferred) as subclasses blended liquid fuel. This currently does not work.

Ideas of solution

I see two options to solve this:

Option 1

Add axioms 'has normal state of matter' value liquid to both E7 and B10.
Then the definitions should be extended:
- B7: B7 is a diesel fuel that consists of fossil diesel fuel and up to 7 % biodiesel and that is liquid.
- E10: E10 is a gasoline fuel that consists of (fossil) gasoline and up to 10 % ethanol and that is liquid.

Class: B7
    SubClassOf:
        'diesel fuel'
        ('has part' some biodiesel)
         and ('has part' some 'fossil diesel fuel')
        'has normal state of matter' value liquid

Class: E10
    SubClassOf:
        'gasoline fuel'
        ('has part' some gasoline)
         and ('has part' some bioethanol)
        'has normal state of matter' value liquid

Option 2

Make E7 and B10 directly subclasses of blended liquid fuel' with the new definitions:
- B7: B7 is a ~diesel fuel~ blended liquid fuel that consists of fossil diesel fuel and up to 7 % biodiesel and that is used as diesel fuel.
- E10: E10 is a gasoline fuel that consists of (fossil) gasoline and up to 10 % ethanol and that is used as a gasoline fuel.

Class: B7
    SubClassOf:
        'blended liquid fuel'
        ('has part' some biodiesel)
 and ('has part' some 'fossil diesel fuel')
        'has role' some 'diesel fuel role'

Class: E10
    SubClassOf:
        'blended liquid fuel'
        ('has part' some gasoline)
         and ('has part' some bioethanol)
        'has role' some 'gasoline fuel role'

Pros and cons

The definitions and asserted axioms in option 1 focus on the fact that B7 and E10 are diesel resp. gasoline fuels while option 2 focus a bit more on the fact that B7 and E10 are blended liquid fuels.

Workflow checklist

[ ] I discussed the issue with someone else than me before working on a solution
[ ] I already read the latest version of the workflow for this repository
[ ] The goal of this ontology is clear to me

I am aware that

[ ] every entry in the ontology should have a definition
[ ] classes should arise from concepts rather than from words

stap-m commented 10 months ago

I like option 1.

l-emele commented 10 months ago

Okay, then I'll implement option 1.

OpenEnergyPlatform / ontology