search

OpenEnergyTools / scl-lib

5 stars 4 forks source link

confRev updated incorrectly on SampledValue Control Block #102

Closed danyill closed 1 month ago

danyill commented 1 month ago

We think the confRev is not being correctly updated on some control block types.

For instance in SV control blocks, an update of the smvID should not result in a change to confRev:

image

However we update this on almost any change:

https://github.com/OpenEnergyTools/scl-lib/blob/bd020d3a5534ec9da2915c5f1c7ff5518214b9d6/tSampledValueControl/updateSampledValueControl.ts#L9-L78

Unless there is a TISSUE clarifying this, I think this may need to be changed for GOOSE, SV and maybe also ReportControl blocks.

I'll be happy to prepare a PR.

danyill commented 1 month ago

Looking at this a little more closely I think L75 could be included in the preceding if block (i.e. between L72 and L73) and this would be sufficient.

We would also be very delighted for a new release of the oscd-publisher plugin with this improvement (i.e. a dependency update) which is where we first spotted the issue.

JakobVogelsang commented 1 month ago

Thank you for the hint. I will make an update here.

JakobVogelsang commented 1 month ago

Thanks for spotting this one!! This is exactly why such a library makes sense as on open source implementation.