search

OpenEnergyTools / scl-lib

5 stars 4 forks source link

tExtRef: Match Source Attributes doesn't match srcLNClass correctly #85

Closed danyill closed 7 months ago

danyill commented 7 months ago

This function doesn't appear to correctly match srcLNClass. If it is missing it should default to LLN0.

I think we need something like:

 extRef.getAttribute("srcLNClass") ?? "LLN0" === srcLNClass

https://github.com/OpenEnergyTools/scl-lib/blob/7cbe03ae29c508af819ae57892b84ea73ca42345/tExtRef/matchSrcAttributes.ts#L8-L22

danyill commented 7 months ago

I can do a PR for this and add a test at some stage soon.

JakobVogelsang commented 7 months ago

Please do 🥳