search

OpenFeign / feign-annotation-error-decoder

Apache License 2.0
51 stars 9 forks source link

feign.Request object now supported as exception constructor parameter #23

Closed StefanFellinger closed 5 years ago

StefanFellinger commented 5 years ago

The ExceptionGenerator now

StefanFellinger commented 5 years ago

Hey @saintf,

i've two questions: First, is this pull request fine for you? And second most important for me, when do you plan to release?

Best regards,

Stefan

StefanFellinger commented 5 years ago

Hey @saintf ,

how are you? I would be happy if you tell me some time horizon i can calculate with getting a new version including my pull request :-)

Have a good time,

Stefan

saintf commented 5 years ago

Sorry Stefan!! Work and personal life have been brutal. I'll look at it this weekend and if all good I'll release it then. Sorry it took me so long!!!

On Wed, 17 Jul 2019, 18:30 StefanFellinger, notifications@github.com wrote:

Hey @saintf https://github.com/saintf ,

how are you? I would be happy if you tell me some time horizon i can calculate with getting a new version including my pull request :-)

Have a good time,

Stefan

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/OpenFeign/feign-annotation-error-decoder/pull/23?email_source=notifications&email_token=ADJ2TCWULRFSD4V5KMAFESDP75CIVA5CNFSM4HYQRYIKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2E65VA#issuecomment-512356052, or mute the thread https://github.com/notifications/unsubscribe-auth/ADJ2TCULMIKGIR6SONLEXODP75CIVANCNFSM4HYQRYIA .

StefanFellinger commented 5 years ago

Hey @saintf ,

oh i know, luckily i "only" have a bit of water in one of my cellar rooms, comming from somewhere outside. Now i have a new hobby: finding the source of water leaking. Most important family and friends are all healthy. So we actually work on a project replacing some legacy systems, so i have many items on my todos list.

saintf commented 5 years ago

Code looks good. thanks for paying attention to style and covering with tests (much much appreciated ;)). I've merged - and will release shortly.