OpenFeign / feign

Feign makes writing java http clients easier
Apache License 2.0
9.52k stars 1.93k forks source link

Should we endorse jitpack? #842

Open velo opened 6 years ago

velo commented 6 years ago

https://jitpack.io/#Openfeign/feign

Looks interesting, would people from consuming latest straight from master, w/o waiting for dev team.

kdavisk6 commented 6 years ago

What do you think our support load will be supporting something like this? Are we OK with folks using "unreleased" builds?

velo commented 6 years ago

What do you think our support load will be supporting something like this?

Good question?! I have no clue if that could generate support calls.

Are we OK with folks using "unreleased" builds?

Speaking for myself, from time to time I need "unreleased" builds... and it's painful So, wonder if we could alleviate the pain from our users

velo commented 4 years ago

I had the need to use a snapshot, and, one annoying thing is the different group id

    <dependency>
      <groupId>com.github.openfeign.feign</groupId>
      <artifactId>feign-hc5</artifactId>
      <version>187cba9c5d</version>
    </dependency>

Using io.github.openfeign doesn't work at all.

But other than that works like a charm, just need to add the repository

    <repositories>
        <repository>
            <id>jitpack.io</id>
            <url>https://jitpack.io</url>
        </repository>
    </repositories>
kdavisk6 commented 4 years ago

Do we have that group registered? Changing that would be a big deal if we had to do that across the board. Is that what we need to do here?

velo commented 4 years ago

That is jitpack convention.

If we had a custom domain, it would be possible to map, but since we are using github.io, there ain't much we can do.

I guess we can advice about jitpack usage, but warn that group id is going to be different.