Closed RiesBen closed 9 months ago
Hello @RiesBen! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
src/kartograf/filters/element_change.py
:Line 57:78: W291 trailing whitespace Line 70:1: W293 blank line contains whitespace Line 70:1: W391 blank line at end of file
src/kartograf/tests/test_element_filters.py
:Line 45:46: W291 trailing whitespace
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
9757264
) 96.16% compared to head (3a4e81b
) 96.21%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@richardjgowers yes that is a very important change filter (benzene to cyclohex). But we would need to check the all ring atoms, I think. Therefore this would be a ring-change filter, similar to your whole ring filter.
This PR adds a filter for hybridization_changes of atoms, disallowing them.