OpenFreeEnergy / kartograf

This package contains tools for setting up hybrid-topology FE calculations
https://kartograf.readthedocs.io/
MIT License
25 stars 2 forks source link

adding hybridization change filter #35

Closed RiesBen closed 9 months ago

RiesBen commented 9 months ago

This PR adds a filter for hybridization_changes of atoms, disallowing them.

pep8speaks commented 9 months ago

Hello @RiesBen! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 57:78: W291 trailing whitespace Line 70:1: W293 blank line contains whitespace Line 70:1: W391 blank line at end of file

Line 45:46: W291 trailing whitespace

Comment last updated at 2024-01-30 18:39:36 UTC
codecov[bot] commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (9757264) 96.16% compared to head (3a4e81b) 96.21%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #35 +/- ## ========================================== + Coverage 96.16% 96.21% +0.04% ========================================== Files 13 13 Lines 574 581 +7 ========================================== + Hits 552 559 +7 Misses 22 22 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

RiesBen commented 9 months ago

@richardjgowers yes that is a very important change filter (benzene to cyclohex). But we would need to check the all ring atoms, I think. Therefore this would be a ring-change filter, similar to your whole ring filter.