Refactoring Code for Network tool & Network Planner - Concatenators

[RiesBen]

This PR does:

• harmonize the code
• make stuff more elegant
• add unit tests.

[pep8speaks]

Hello @RiesBen! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

• In the file src/konnektor/network_planners/concatenators/_abstract_network_concatenator.py:

Line 66:9: E125 continuation line with same indent as next logical line

• In the file src/konnektor/network_planners/concatenators/cyclic_concatenator.py:

Line 41:80: E501 line too long (80 > 79 characters) Line 51:9: E125 continuation line with same indent as next logical line

• In the file src/konnektor/network_planners/concatenators/max_concatenator.py:

Line 43:9: E125 continuation line with same indent as next logical line

• In the file src/konnektor/network_planners/concatenators/mst_concatenator.py:

Line 45:9: E125 continuation line with same indent as next logical line

• In the file src/konnektor/network_planners/generators/two_dimensional_network_planners.py:

Line 19:80: E501 line too long (106 > 79 characters) Line 30:80: E501 line too long (88 > 79 characters) Line 46:80: E501 line too long (144 > 79 characters) Line 48:80: E501 line too long (148 > 79 characters) Line 143:80: E501 line too long (83 > 79 characters) Line 150:80: E501 line too long (88 > 79 characters) Line 166:80: E501 line too long (144 > 79 characters) Line 168:80: E501 line too long (148 > 79 characters) Line 178:38: E251 unexpected spaces around keyword / parameter equals Line 178:40: E251 unexpected spaces around keyword / parameter equals

• In the file src/konnektor/network_tools/clustering/_abstract_clusterer.py:

Line 12:5: E122 continuation line missing indentation or outdented

• In the file src/konnektor/network_tools/clustering/charge_clustering.py:

Line 16:5: E122 continuation line missing indentation or outdented

• In the file src/konnektor/network_tools/misc.py:

Line 29:5: E731 do not assign a lambda expression, use a def Line 55:5: E731 do not assign a lambda expression, use a def

• In the file src/konnektor/tests/network_planners/concatenators/test_bipartite_MST_connector.py:

Line 30:32: W292 no newline at end of file

• In the file src/konnektor/tests/network_planners/concatenators/test_bipartite_max_concatenator.py:

Line 7:80: E501 line too long (85 > 79 characters) Line 9:80: E501 line too long (100 > 79 characters) Line 12:1: E265 block comment should start with '# '

• In the file src/konnektor/tests/network_planners/generators/test_maximal_network_planner.py:

Line 8:80: E501 line too long (100 > 79 characters) Line 10:80: E501 line too long (89 > 79 characters)

• In the file src/konnektor/tests/network_planners/generators/test_mst_netwok_planner.py:

Line 12:80: E501 line too long (128 > 79 characters) Line 13:80: E501 line too long (89 > 79 characters)

• In the file src/konnektor/tests/network_planners/generators/test_radial_network_planner.py:

Line 9:80: E501 line too long (100 > 79 characters) Line 11:80: E501 line too long (89 > 79 characters)

• In the file src/konnektor/tests/network_planners/generators/test_rmst_netwok_planner.py:

Line 12:80: E501 line too long (128 > 79 characters) Line 13:80: E501 line too long (89 > 79 characters)

• In the file src/konnektor/tests/network_tools/test_clustering.py:

Line 5:80: E501 line too long (80 > 79 characters)

• In the file src/konnektor/tests/network_tools/test_misc.py:

Line 2:80: E501 line too long (80 > 79 characters)

• In the file src/konnektor/tests/test_toy_data.py:

Line 6:80: E501 line too long (82 > 79 characters) Line 112:80: E501 line too long (104 > 79 characters) Line 114:80: E501 line too long (80 > 79 characters)

• In the file src/konnektor/utils/toy_data.py:

Line 102:80: E501 line too long (80 > 79 characters) Line 149:5: E125 continuation line with same indent as next logical line Line 192:80: E501 line too long (83 > 79 characters)

Comment last updated at 2024-05-10 12:58:55 UTC

[codecov[bot]]

Codecov Report

Attention: Patch coverage is 88.99371% with 35 lines in your changes are missing coverage. Please review.

Project coverage is 76.19%. Comparing base (bd8f16c) to head (cfcdc27).

Files	Patch %	Lines
...work_planners/concatenators/cyclic_concatenator.py	0.00%	29 Missing :warning:
src/konnektor/network_tools/misc.py	88.88%	2 Missing :warning:
src/konnektor/tests/test_toy_data.py	92.30%	2 Missing :warning:
...ers/generators/two_dimensional_network_planners.py	66.66%	1 Missing :warning:
src/konnektor/utils/toy_data.py	96.29%	1 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #40 +/- ## ========================================== + Coverage 71.75% 76.19% +4.43% ========================================== Files 58 62 +4 Lines 1703 1861 +158 ========================================== + Hits 1222 1418 +196 + Misses 481 443 -38 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

[RiesBen]

coverage will be increased here: #41