search

OpenGATE / Gate

Official public repository of Gate
http://www.opengatecollaboration.org
GNU Lesser General Public License v3.0
236 stars 263 forks source link

Incorrect wiki link to physics list builder mechanism #189

Closed bersbersbers closed 6 years ago

bersbersbers commented 6 years ago

I get this warning:

[Physic-0] WARNING: manual physic lists are being deprecated. Please, use physic list builder mechanism instead. Related documentation can be found at: http://wiki.opengatecollaboration.org/index.php/Users_Guide_V7.0:Setting_up_the_physics

However, "Users Guide V7.0:Setting up the physics" says "There is currently no text in this page."

djboersma commented 6 years ago

Hi! We removed old versions, we only provide the wiki that pertains to the latest release. Though much of the information should still be valid for old releases (and to be brutally honest: in some topics we are a bit slow in updating, so maybe some topics are more correctly explained for 7.0 than for 8.1).

So look here: http://wiki.opengatecollaboration.org/index.php/Users_Guide:Setting_up_the_physics

Or here: http://www.opengatecollaboration.org/sites/default/files/GATE-UsersGuideV7.0.pdf Page 61.

bersbersbers commented 6 years ago

@djboersma Thanks for the explanation, although I am not sure I understand why you closed this issue without changing any code (as far as I can see). If I understand correctly, you are telling me that http://wiki.opengatecollaboration.org/index.php/Users_Guide_V7.0:Setting_up_the_physics has been removed and will not be provided in the future. So the link in the warning is still wrong, isn't it? Shouldn't some piece of code, like https://github.com/OpenGATE/Gate/blob/02fd3f6d10bf7e94c0afe7a2f6c0290045678eb3/source/physics/src/GatePhysicsList.cc#L193, be changed then to prevent future users from hitting the same issue?

djboersma commented 6 years ago

Ah yes, sorry! I blindly assumed that you were using version 7.0 and I am usually a bit impatient when we get questions about old releases. But this wrong link was still advertised in the develop version, you are totally right. So I think I fixed this now in the code, commit 991c42148439bba1e922848e910cd89bb0ef0aca. Thanks for keeping me alert!