search

OpenGeoscience / geojs

High-performance visualization and interactive data exploration of scientific and geospatial location aware datasets
https://opengeoscience.github.io/geojs
Apache License 2.0
441 stars 75 forks source link

perf: Update option for addAnnotation. #1161

Closed manthey closed 2 years ago

manthey commented 2 years ago

Add an option to skip updating the layer when adding an annotation.

netlify[bot] commented 2 years ago

✔️ Deploy Preview for opengeoscience-geojs ready!

🔨 Explore the source changes: 8b3fddaf3ba64cb26ed280389c682f9489f585ba

🔍 Inspect the deploy log: https://app.netlify.com/sites/opengeoscience-geojs/deploys/61f2b028573aa500077f7de6

😎 Browse the preview: https://deploy-preview-1161--opengeoscience-geojs.netlify.app

manthey commented 2 years ago

@boucaud This is a fairly simple change, so I'm happy to merge it once CI has passed.

boucaud commented 2 years ago

Thank you David !

Could we do the same thing for removeAnnotation() ?

manthey commented 2 years ago

Could we do the same thing for removeAnnotation() ?

Oddly, we already had that flag on removeAnnotation.

boucaud commented 2 years ago

Oddly, we already had that flag on removeAnnotation.

Oh that's true, I just assumed it was the same

github-actions[bot] commented 2 years ago

:tada: This PR is included in version 1.6.3 :tada:

The release is available on:

Your semantic-release bot :package::rocket: