search

OpenHistoricalMap / issues

File your issues here, regardless of repo until we get all our repos squared away; we don't want to miss anything.
Creative Commons Zero v1.0 Universal
19 stars 1 forks source link

Main/Historical: Need to ensure glaciers are rendered in a visually distinctive way to support State of the Map 2024 glacier mapping #781

Closed jeffreyameyer closed 6 months ago

jeffreyameyer commented 6 months ago

Style change requested

We will be mapping the history of glacier retreat at State of the Map 2024. As part of that, it would be great if the glaciers showed up in some meaningful way in our tiles.

Currently, the testbed doesn't show any special treatment for areas marked as natural=glacier:

Monosnap OpenHistoricalMap 2024-05-07 11-20-23

Good news is that a quick check of the vtiles confirms that the area is making it through, with type=glacier.

Here is the OSM treatment for Montana's Sexton Glacier:

Monosnap OpenStreetMap 2024-05-07 11-24-34

and a wider view of the surrounding glaciers:

Monosnap Node: ‪Sexton Glacier‬ (‪357930467‬) | OpenStreetMap 2024-05-07 11-26-46
vknoppkewetzel commented 6 months ago

Noting the semi-urgent tag here, will get to work on this this week

jeffreyameyer commented 6 months ago

Lmml

On Tue, May 14, 2024, 6:57 PM Vanessa Knoppke-Wetzel < @.***> wrote:

Noting the semi-urgent tag here, will get to work on this this week

— Reply to this email directly, view it on GitHub https://github.com/OpenHistoricalMap/issues/issues/781#issuecomment-2110705223, or unsubscribe https://github.com/notifications/unsubscribe-auth/AALM4EWXVNKW6FF3SBGUT73ZCI7AFAVCNFSM6AAAAABHLQTB3SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMJQG4YDKMRSGM . You are receiving this because you authored the thread.Message ID: @.***>

vknoppkewetzel commented 6 months ago

I've updated styling for "type = glacier" as seen in demo test style: https://openhistoricalmap.github.io/mbgl-timeslider/demo/#15.096/70.00318/-42.29783/2023,-4000-2023

I am not sure where glacier data exists globally, tried a couple places and didn't see any type=glacier in the spots I checked

Also possibly I had trouble finding examples --> It looks like the data itself doesn't exist until zoom 13? Styling-wise, we have it set to come in at z9, but it doesn't pop up until z13. Looks to be the case for a few things in landuse_areas https://vtiles.openhistoricalmap.org/#12.92/70.00449/-42.29434

vknoppkewetzel commented 6 months ago

@erictheise styling is good to go! I have this updated in map-styles in the historical style.

I was flagging above that glaciers won't show up before z13 because of the data itself not existing, but styling-wise if that changes, the style will update automtically :)

Tl;dr getting this in would be great! Thank you :D

vknoppkewetzel commented 6 months ago

These are in main/historical