search

OpenHistoricalMap / issues

File your issues here, regardless of repo until we get all our repos squared away; we don't want to miss anything.
Creative Commons Zero v1.0 Universal
19 stars 1 forks source link

Create solution for run-time styling of brower-language name values #854

Open jeffreyameyer opened 3 months ago

jeffreyameyer commented 3 months ago

What's your idea for a cool feature that would help you use OHM better. Now that we have upgraded our stylesheets to expressions (#775), in order to be able to provide the stylesheet with style-able local names (browser-specific #481 & browser+local #799) based on all the localized name variations available (#679), we'll still need to work some magic on all of those name:*=* tags.

There are a couple ways of handling this, either in the client or on the server side.

@1ec5 has some pointers to relevant tickets to help with deciding which of these approaches we may pursue.

There are currently no real workarounds to this problem.

1ec5 commented 3 months ago

I think https://github.com/OpenHistoricalMap/issues/issues/481#issuecomment-2163593373 captures all the next steps. The runtime styling to switch languages requires either pulling in openstreetmap/openstreetmap-website#4042 (minus the addition of the MapTiler style) or separately installing the mapbox-gl-language plugin, as a precursor to the bilingual labeling that’s blocked by ZeLonewolf/openstreetmap-americana#914.

jeffreyameyer commented 3 months ago

@danrademacher - not sure who should chose between the 2 options @1ec5 identifies above (or create something altogether different), but let's have a discussion on which is wisest path to choose. I'm most interested in whatever keeps us on a path for the 2-line labels most efficiently.

1ec5 commented 3 months ago

openstreetmap/openstreetmap-website#4042 has the advantage of hooking into the user’s existing openhistoricalmap.org language preference. Separately installing mapbox-gl-language might let us get away with a lighter touch on the codebase, but it can only respond to the browser’s language preference. Neither solution precludes installing bilingual labels down the line.

1ec5 commented 3 months ago

OpenHistoricalMap/openhistoricalmap-embed#8 implements this feature for the embed site. However, we’ll still need to leave this issue open to track similar changes to the main site.