search

OpenKMIP / PyKMIP

A Python implementation of the KMIP specification.
Apache License 2.0
272 stars 134 forks source link

Add custom attribute support for SymmetricKey object #654

Closed locula closed 1 year ago

locula commented 3 years ago

I previously opened Allow custom attributes #650 to add custom attribute support for SecretData objects. This PR is to add the same support for Symmetric Keys.

locula commented 3 years ago

@PeterHamilton could you please take a look at this?

locula commented 2 years ago

@PeterHamilton following up on this since this functionality is still being used, and it would be very helpful to get this merged. The changes are almost identical to those from https://github.com/OpenKMIP/PyKMIP/pull/650 which was merged.

locula commented 2 years ago

It looks like there is already a tests/pie/objects/test_application_specific_information.py file. Is there something specific you would like me to add unit tests for?

arp102 commented 2 years ago

It looks like there is already a tests/pie/objects/test_application_specific_information.py file. Is there something specific you would like me to add unit tests for?

We could test the functionality added in #654 and #650 by registering a Key object and checking the attributes. The test could be part of either kmip/tests/integration/services/test_proxykmipclient.py (which does actual registration) or kmip/tests/unit/pie/test_client.py (which simulates registration).