search

OpenLiberty / liberty-language-server

The Liberty Config Language Server provides language server features for Liberty server configuration files through any of the supported client IDEs.
Eclipse Public License 2.0
5 stars 11 forks source link

Add git.properties file with build id #240

Open scottkurz opened 10 months ago

scottkurz commented 10 months ago

I copied this from StackOverflow somewhere. Should the git.properties really go right in the root or META-INF? I'm not even sure why I have the build-helper-maven-plugin and not just the other plugin. Leaving as a draft.

cherylking commented 10 months ago

Is this going to play well with the maven-shade-plugin we are using to control what goes into the build artifact?

scottkurz commented 10 months ago

Is this going to play well with the maven-shade-plugin we are using to control what goes into the build artifact?

I think it does, for now...the git.properties file still seems to appear in the final artifact.