search

OpenLiberty / liberty-language-server

The Liberty Config Language Server provides language server features for Liberty server configuration files through any of the supported client IDEs.
Eclipse Public License 2.0
5 stars 11 forks source link

Use of guava com.google.common.io.Closeables isn't worth dragging in the entire dependency #254

Closed scottkurz closed 9 months ago

scottkurz commented 9 months ago

It adds footprint. more of a surface for the various scans....and it looks like just a wrapper with a bit of error handling around https://github.com/google/guava/blob/master/guava/src/com/google/common/io/Closeables.java which we are only using in one place (ParentProcessWatcher). Looks like we could rewrite fairly easily.

cherylking commented 9 months ago

guava is pulled in by our dependencies...the only reason you see it in our pom.xml is to override the version (due to a CVE). So I don't think we can avoid having the guava dependency even if we stop using that particular class...just fyi.

scottkurz commented 9 months ago

guava is pulled in by our dependencies...the only reason you see it in our pom.xml is to override the version (due to a CVE). So I don't think we can avoid having the guava dependency even if we stop using that particular class...just fyi.

Yeah, you're right. Nevermind.