NullpointerException in JSP after upgrade

[DantePichardo]

Describe the bug
Upgraded to 21.0.0.9 with fix IFPH39418. The eba web app no longer works, when I try to open the login page, it crashes.

BundleLoader[com.ibm.ws.webcontainer_1.1.56.cl210920210824-2341] found local class com.ibm.websphere.servlet.response.StoredResponseCompat 13ms ModuleClassLoader[com.ibm.ws.webcontainer_1.1.56.cl210920210824-2341].loadClass(javax.servlet.http.HttpServletResponseWrapper) BundleLoader[com.ibm.ws.webcontainer_1.1.56.cl210920210824-2341].findClass(javax.servlet.http.HttpServletResponseWrapper) BundleLoader[com.ibm.ws.webcontainer_1.1.56.cl210920210824-2341] loading from import package: javax.servlet.http -> [com.ibm.websphere.javaee.servlet.3.1_1.0.56.cl210920210824-2341] BundleLoader[com.ibm.websphere.javaee.servlet.3.1_1.0.56.cl210920210824-2341].findLocalClass(javax.servlet.http.HttpServletResponseWrapper) BundleLoader[com.ibm.websphere.javaee.servlet.3.1_1.0.56.cl210920210824-2341] found local class javax.servlet.http.HttpServletResponseWrapper 0ms BundleLoader[com.ibm.ws.webcontainer_1.1.56.cl210920210824-2341] found local class com.ibm.websphere.servlet.response.StoredResponse 33ms BundleLoader[com.ibm.ws.webcontainer_1.1.56.cl210920210824-2341] found local class com.ibm.websphere.servlet.filter.ChainedResponse 36ms ModuleClassLoader[com.ibm.ws.webcontainer_1.1.56.cl210920210824-2341].loadClass(com.ibm.ws.webcontainer.util.ApplicationErrorUtils) BundleLoader[com.ibm.ws.webcontainer_1.1.56.cl210920210824-2341].findClass(com.ibm.ws.webcontainer.util.ApplicationErrorUtils) BundleLoader[com.ibm.ws.webcontainer_1.1.56.cl210920210824-2341].findLocalClass(com.ibm.ws.webcontainer.util.ApplicationErrorUtils) ModuleClassLoader[com.ibm.ws.webcontainer_1.1.56.cl210920210824-2341 - /Users/dantepichardo/Documents/development/522/vtd_web/server/server/lib/com.ibm.ws.webcontainer_1.1.56.jar].findClassImpl(com.ibm.ws.webcontainer.util.ApplicationErrorUtils) read 6608 bytes from /Users/dantepichardo/Documents/development/522/vtd_web/server/server/lib/com.ibm.ws.webcontainer_1.1.56.jar!/com/ibm/ws/webcontainer/util/ApplicationErrorUtils.class defining class com.ibm.ws.webcontainer.util.ApplicationErrorUtils BundleLoader[com.ibm.ws.webcontainer_1.1.56.cl210920210824-2341] found local class com.ibm.ws.webcontainer.util.ApplicationErrorUtils 14ms ModuleClassLoader[com.ibm.ws.webcontainer_1.1.56.cl210920210824-2341].loadClass(java.lang.StackTraceElement) ModuleClassLoader[com.ibm.ws.webcontainer_1.1.56.cl210920210824-2341].loadClass(com.ibm.websphere.ras.TruncatableThrowable) BundleLoader[com.ibm.ws.webcontainer_1.1.56.cl210920210824-2341].findClass(com.ibm.websphere.ras.TruncatableThrowable) BundleLoader[com.ibm.ws.webcontainer_1.1.56.cl210920210824-2341] loading from import package: com.ibm.websphere.ras -> [org.eclipse.osgi_3.16.0.cl210920210824-2341] [ERROR ] SRVE0777E: Exception thrown by application class 'java.io.File.:277' java.lang.NullPointerException at java.io.File.(File.java:277) at com.ibm.ws.jsp.webcontainerext.JspDependent.isOutdated(JspDependent.java:84) at [internal classes]

in this line:

getServletContext( ).getRequestDispatcher( "/login.jsp" ).forward( request, response );

Steps to Reproduce
Open the login page, using /Login path, which forwards to login.jsp

Expected behavior
Open the login page

Diagnostic information:

• OpenLiberty Version: [21.0.0.9]

• Affected feature(s) [jsp-2.2]

• Java Version: Java HotSpot(TM) 64-Bit Server VM, version 1.8.0_241-b07 16_Jan_2020_14_44 Mac OS X x64(SR6 FP5) (en_MX) java version "1.8.0_241" Java(TM) 2 Runtime Environment, Standard Edition (IBM build 1.8.0_241-b07 16_Jan_2020_14_44 Mac OS X x64(SR6 FP5)) Java HotSpot(TM) 64-Bit Server VM (build 25.241-b07, mixed mode) IBM Java ORB build orbdev-userlvl-20200106.1711 XML build XL TXE Java 1.0.62 XML build IBM JAXP 1.6.1 XML build XML4J 4.5.31

• server.xml configuration

  jsp-2.2 jsf-2.0 wab-1.0 jndi-1.0 servlet-3.1 appSecurity-2.0 usr:hydraJAAS ssl-1.0 websocket-1.1 ejbLite-3.1 jaxrs-1.1 cdi-1.0 localConnector-1.0 jwt-1.0

  <jaasLoginContextEntry id="Jaas2.HydraCIM" name="Jaas2.HydraCIM">
  <loginModuleRef>Jaas2.HydraCIM</loginModuleRef>

  CIMTestJaasLoginModuleImpl WSTrustLoginModule1 CIMJaasHelper WSTrustLoginModule2 CIMJaasHelper WSTrustLoginModule1 WSTrustLoginModule2 ESSTestJaasLoginModuleImpl LDAPLoginModule CIMJaasHelper LDAPLoginModule LDAPTestJaasLoginModule

• If it would be useful, upload the messages.log file found in $WLP_OUTPUT_DIR/messages.log

Additional context

[epj]

Can you please recreate the issue with this trace in effect: *=info:com.ibm.ws.webcontainer*=all:com.ibm.wsspi.webcontainer*=all:HTTPChannel=all:GenericBNF=all:com.ibm.ws.jsp=finer

I don't need the trace from server startup, just start the trace before your login is attempted for the first time on the server.

Send along trace.log and messages.log. Thanks @DantePichardo .

[DantePichardo]

ffdc_21.10.11_20.46.20.0.log messages.log trace_21.10.11_21.04.12.0.log

[epj]

The trace does not include the start of the login.jsp request. Were there additional trace logs besides the one? Can you please also send up the web.xml and ibm-web-ext.xml for your app?

[DantePichardo]

trace_21.10.11_21.04.10.0.log trace_21.10.11_21.04.10.1.log trace_21.10.11_21.04.10.2.log trace_21.10.11_21.04.11.0.log

trace_21.10.11_21.04.11.1.log trace_21.10.11_21.04.11.2.log trace_21.10.11_21.04.11.3.log

[DantePichardo]

web.xml.log

I changed the extension so github allows me to upload those.

[DantePichardo]

I closed ticket by mistake, please re-open if needed.

[epj]

[10/11/21 21:04:11:433 CDT] 00000496 id=00000000 com.ibm.ws.jsp.webcontainerext.JSPExtensionContext 2 getRealPath FileNotFound exception while obtaining realPath: null, exception was: java.io.FileNotFoundException: /WEB-INF/tlds/storage.tld

This error is trapped before the NPE but the missing file appears to be the cause of the NPE. Can you check that /WEB-INF/tlds/storage.tld exists in your application? If it is indeed missing, please either add the file or remove its taglib call from the JSP, and see if the NPE goes away.

Meanwhile, our code shouldn't hit a NPE so I'll continue to work on a fix for it.