Create More Comprehensive Jakarta Tag SQL Tests

OpenLiberty / open-liberty

Open Liberty is a highly composable, fast to start, dynamic application server runtime environment

https://openliberty.io

Eclipse Public License 2.0

1.15k stars 588 forks source link

Create More Comprehensive Jakarta Tag SQL Tests #21719

Open volosied opened 2 years ago

volosied commented 2 years ago

The JSTLTest we have only verify the import, not any tags.

https://github.com/OpenLiberty/open-liberty/blob/145e8d582cf52931276f607447f47e328727a084/dev/com.ibm.ws.jsp.2.3_fat/test-applications/TestJSTL.war/resources/sqlTagLibImport.jsp#L11-L20

https://github.com/OpenLiberty/open-liberty/blob/145e8d582cf52931276f607447f47e328727a084/dev/com.ibm.ws.jsp.2.3_fat/fat/src/com/ibm/ws/jsp23/fat/tests/JSTLTests.java#L137-L150

Update the corresponding JSTLTest EE10 Class & application, too.

pnicolucci commented 1 year ago

Pushing this out of EE10 as nothing has changed in this area for EE10 and this is just existing technical debt that we should look at increasing test coverage across our Jakarta Tags features in the future.