OpenLightingProject / open-fixture-library

A library and website for lighting technology's DMX fixture definition files.
https://open-fixture-library.org/
MIT License
187 stars 62 forks source link

Add fixture `american-dj/adj-fog` #4078

Closed FloEdelmann closed 1 month ago

FloEdelmann commented 1 month ago

Thank you NEXTONPRO!

github-actions[bot] commented 1 month ago

Export files validity

(Output of test script tests/github/exports-valid.js.)

Test the exported files of selected fixtures against the plugins' export tests. You can run a plugin's export tests by executing: $ node cli/run-export-test.js -p <plugin name> <fixtures>

✔️ american-dj / adj-fog: d-light / attributes-correctness
  • ✔️ american-dj/adj-fog-fog.xml
✔️ american-dj / adj-fog: dmxcontrol3 / channel-numbers
  • ✔️ american-dj-adj-fog-fog.xml
✔️ american-dj / adj-fog: dragonframe / json-schema-conformity
  • ✔️ american-dj/adj-fog.json
  • ✔️ manufacturers.json
✔️ american-dj / adj-fog: millumin / json-schema-conformity
  • ✔️ american-dj/adj-fog.json
american-dj / adj-fog: qlcplus_4.12.2 / fixture-tool-validation
  • ❌ fixtures/American-DJ-Adj_fog.qxfNamespace(map=False, convert=None, validate=['.']) Starting validation ./manufacturer/fixture.qxf: Invalid physical dimensions detected ./manufacturer/fixture.qxf: Invalid power consumption 1 definitions processed. 2 errors detected
american-dj / adj-fog: qlcplus_4.12.2 / xsd-schema-conformity
  • ❌ fixtures/American-DJ-Adj_fog.qxfElement '{http://www.qlcplus.org/FixtureDefinition}Dimensions', attribute 'Weight': [facet 'minExclusive'] The value '0' must be greater than '0'.
    Element '{http://www.qlcplus.org/FixtureDefinition}Dimensions', attribute 'Width': '0' is not a valid value of the atomic type 'xs:positiveInteger'.
    Element '{http://www.qlcplus.org/FixtureDefinition}Dimensions', attribute 'Height': '0' is not a valid value of the atomic type 'xs:positiveInteger'.
    Element '{http://www.qlcplus.org/FixtureDefinition}Dimensions', attribute 'Depth': '0' is not a valid value of the atomic type 'xs:positiveInteger'.
kengruven commented 1 month ago

This file only has a 1ch mode (omitting the 2/3/5/7ch modes), and it's not even correct for that.

Note that the "Fog Fury Jett" is extremely similar to the "Fog Fury Jett Pro" which is already in OFL (american-dj/fog-fury-jett-pro). To make the non-pro version, you basically just need to remove Green 2 and UV, and add Color Macro Preview to the Fog channel.