OpenLightingProject / open-fixture-library

A library and website for lighting technology's DMX fixture definition files.
https://open-fixture-library.org/
MIT License
195 stars 66 forks source link

Add fixture `noname-china/par` #4407

Closed FloEdelmann closed 1 week ago

FloEdelmann commented 1 week ago

Fixture warnings / errors

Thank you Nikolay and Noname_China_Par_RGBWU!

github-actions[bot] commented 1 week ago

Export files validity

(Output of test script tests/github/exports-valid.js.)

Test the exported files of selected fixtures against the plugins' export tests. You can run a plugin's export tests by executing: $ node cli/run-export-test.js -p <plugin name> <fixtures>

✔️ noname-china / par: d-light / attributes-correctness
  • ✔️ noname-china/par-Mode.xml
✔️ noname-china / par: dmxcontrol3 / channel-numbers
  • ✔️ noname-china-par-Mode.xml
noname-china / par: dragonframe / json-schema-conformity
  • ❌ noname-china/par.jsonfixture/modes/0/name "Mode" must match pattern "^((?!mode)(?!Mode).)*$"
  • ✔️ manufacturers.json
noname-china / par: millumin / json-schema-conformity
  • ❌ noname-china/par.jsonfixture/modes/0/name "Mode" must match pattern "^((?!mode)(?!Mode).)*$"
noname-china / par: qlcplus_4.12.2 / fixture-tool-validation
  • ❌ fixtures/Noname-China-Par.qxfNamespace(map=False, convert=None, validate=['.']) Starting validation ./manufacturer/fixture.qxf: Invalid physical dimensions detected ./manufacturer/fixture.qxf: Invalid power consumption 1 definitions processed. 2 errors detected
noname-china / par: qlcplus_4.12.2 / xsd-schema-conformity
  • ❌ fixtures/Noname-China-Par.qxfElement '{http://www.qlcplus.org/FixtureDefinition}Dimensions', attribute 'Weight': [facet 'minExclusive'] The value '0' must be greater than '0'.
    Element '{http://www.qlcplus.org/FixtureDefinition}Dimensions', attribute 'Width': '0' is not a valid value of the atomic type 'xs:positiveInteger'.
    Element '{http://www.qlcplus.org/FixtureDefinition}Dimensions', attribute 'Height': '0' is not a valid value of the atomic type 'xs:positiveInteger'.
    Element '{http://www.qlcplus.org/FixtureDefinition}Dimensions', attribute 'Depth': '0' is not a valid value of the atomic type 'xs:positiveInteger'.
FloEdelmann commented 1 week ago

Without a proper manual or link this is unfortunately impossible to review, so I'll close this as incomplete. Feel free to comment more information.