search

OpenMS / pyopenms-docs

pyOpenMS readthedocs documentation, additional utilities, addons, scripts, and examples.
https://pyopenms.readthedocs.io
Other
42 stars 50 forks source link

DONT MERGE Master+ipynb #414

Closed poshul closed 7 months ago

jpfeuffer commented 8 months ago

Wait, the push should be done automatically for each push on master, right? Or what is this PR for? Not that it's the best solution, but be careful if you change master+ipynb

poshul commented 8 months ago

We don't push the ipynb's back to Master. This was just a lazy way to test the GHA activation. I tried to move forward with https://github.com/OpenMS/pyopenms-docs/pull/320 but using conda in the action spins forever: https://github.com/OpenMS/pyopenms-docs/actions/runs/6719647447/job/18261670898?pr=320

jpfeuffer commented 8 months ago

I think we should use (micro)mamba instead of conda these days. Might help with runtime.

timosachsenberg commented 8 months ago

ah ok came to say same thing... we don't usually push back the notebooks into master (to keep it clean).

poshul commented 8 months ago

Something I did realize is that the way we do it now means past version of the notebooks get wiped every time master+ipynb gets updated.

On Thu, Nov 2, 2023 at 9:39 AM Timo Sachsenberg @.***> wrote:

ah ok came to say same thing... we don't usually push back the notebooks into master (to keep it clean).

— Reply to this email directly, view it on GitHub https://github.com/OpenMS/pyopenms-docs/pull/414#issuecomment-1790291994, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABD3C6VXSAFWNL2S44NFDDYCNL4DAVCNFSM6AAAAAA6ZL6O7OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOJQGI4TCOJZGQ . You are receiving this because you authored the thread.Message ID: @.***>

jpfeuffer commented 8 months ago

Yep. That's mainly why this branch should never be touched manually 😅