search

OpenMediaVault-Plugin-Developers / installScript

script that installs omv-extras and openmediavault if not installed already.
1.1k stars 207 forks source link

Rasbian Bookworm support #132

Closed dikeckaan closed 11 months ago

dikeckaan commented 11 months ago

image

To install OMV on latest rasbian Bookworm i need set beta flag 1 from installer script. You need change or warn people before installing

image

ryecoaaron commented 11 months ago

You need change or warn people before installing

The script does tell them as you clearly see in the last line of your output. I do not want people installing OMV 7.x since it is beta. Once out of beta, it will be removed.

What is concern here? That the lsb-release package is installed?

FalsePhilosopher commented 11 months ago

The readme states it will install omv7 on deb12, so if you download on your limited metered network deb12 and run the install script only to find out that running the install script deb12 will not in fact install omv7 and instead give you an error wasting 500mb of your data limit/time having to instead download another 500mb and do another install is the concern here.

ryecoaaron commented 11 months ago

Where are you getting 500mb? It runs apt-get update, installs lsb-release (just a few Kb), and does a safety check to make sure you aren’t installing a beta version. If you add the -b flag at that point and run it again, it wont download anything for a second time and no data is wasted. That takes a few seconds. If you follow the install guide, you wouldn’t download Bookworm and no beta flag would be needed or time wasted.

https://wiki.omv-extras.org/doku.php?id=omv6:raspberry_pi_install

dikeckaan commented 11 months ago

IMG_3077

As you can see, i can run omv 7 on rpi without issue after set that variable.

There is no waste 500 mb :)

ryecoaaron commented 11 months ago

I am well aware that OMV 7 works on Bookworm but we don't want every random RPi user to be running a beta release of OMV 7 that is still changing. I chose to warn the user instead and force the beta -b flag. There are many, many more RPi users that should not be running a beta version of OMV than users with a metered internet connection. And this situation was only going to be around for a couple of months while OMV 7 is in beta. I'm not sure what else you want me to do.

FalsePhilosopher commented 11 months ago

The 500mb waste is downloading deb12 the see that error when you try to install omv and have to download another 500mb downloading deb11.

ryecoaaron commented 11 months ago

That is avoided by reading the install guide that is linked to in the readme.

FalsePhilosopher commented 11 months ago

That is avoided by reading the install guide that is linked to in the readme.

Have you even read your own readme? Where does it say deb12 is NOT supported? I can find where it says it IS supported

"Notes This script will always install OMV 5.x on Debian 10 (Buster) EOL OMV 6.x on Debian 11 (Bullseye) OMV 7.x on Debian 12 (Bookworm)"

But not a single mention of it NOT being supported. Your readme should reflect the documentation, what's the point of making a quick install script if somebody still needs to dig through documentation for things the readme is not correct about.

ryecoaaron commented 11 months ago

debian 12 is supported though. It just requires OMV 7.x which is currently in beta and the script requires you add a flag.

The readme is just meant to give basic info. The install guide is written by people who are good at writing docs for all skill levels which I am not good at. I’m sorry the readme doesn’t cover enough but that is exactly why the install guides were written.