search

OpenMediaVault-Plugin-Developers / openmediavault-sensors

openmediavault-sensors
11 stars 5 forks source link

Support for upcoming OMV 5? #13

Closed DavidBerdik closed 4 years ago

DavidBerdik commented 5 years ago

When OMV 4 came out, I tried unsuccessfully to contribute to porting this plugin to it, but at this point, I think it would be more valuable to port this plugin to the upcoming OMV 5. Are any of the original developers of this plugin willing to do this?

And what has changed between OMV 3 and OMV 5 that needs to be taken in to account with this plugin? If someone is familiar enough to assist me, I would be happy to help bring this plugin up-to-date.

cptjhmiller commented 5 years ago

It is no so much the plugin but OMV itself.

I could get the plugin working on OMV4 but during testing I found that if you changed any setting to produce different graphs it not only stop monitoring what it was monitoring but it would not change the display of the graphs and continue to display the graphs originally set. I believe this was due to storing something in the browser cache, this would need to change if it is going to work under OMV5.

ryecoaaron commented 5 years ago

@DavidBerdik if you want to see what is needed to port the plugins to OMV 5.x, look at the commit log for some of the most recently ported plugins.

DavidBerdik commented 5 years ago

It is no so much the plugin but OMV itself.

I could get the plugin working on OMV4 but during testing I found that if you changed any setting to produce different graphs it not only stop monitoring what it was monitoring but it would not change the display of the graphs and continue to display the graphs originally set. I believe this was due to storing something in the browser cache, this would need to change if it is going to work under OMV5.

I understand that this is not ideal, but wouldn't clearing your browser cache be a workaround for the problem at least?

@DavidBerdik if you want to see what is needed to port the plugins to OMV 5.x, look at the commit log for some of the most recently ported plugins.

Okay, will do.

lukasmrtvy commented 5 years ago

@cptjhmiller Will You try to port this plugin to OMV5 ?

redskinhu commented 4 years ago

Hi It would be great. Thx

ryecoaaron commented 4 years ago

The plugin will not be ported. Check out netdata

DavidBerdik commented 4 years ago

For anyone interested in using Netdata on their OMV server, there's a very helpful setup guide available here.

https://www.youtube.com/watch?v=vr4LqHUVxtM