OpenMobileAlliance / technical.openmobilealliance.org

Repository for the github pages site for technical.openmobilealliance.org technical pages
https://technical.openmobilealliance.org/
2 stars 0 forks source link

Releases are being displayed as Candidate/Approved when they are Historic #38

Closed jmudge closed 2 years ago

jmudge commented 2 years ago

https://github.com/OpenMobileAlliance/technical.openmobilealliance.org/blob/enablers-table-from-enablers-jsno-data/index.html General. Many releases marked as Historic are not being displayed properly on this web page. Many of the releases have been marked as Historic by copying the entire release version folder and changing the directory suffix to H e.g. "OMA Billing Framework - Billing", "OMA Converged IP Messaging - CPM" and "OMA RCS Profile of RESTful Network APIs - REST_NetAPI_RCSProfile". Historic should be displayed in the index web page but instead Candidate/Approved is displayed that is very misleading.

jpradocueva commented 2 years ago

@jmudge will this problem go away if we set the fuel If -H, then the linked version Vx.y.z is not display

jmudge commented 2 years ago

@jpradocueva surely it is important that users can easily see that releases have been made historic as, of course, they should discontinue using them. It would be better if Historic releases are displayed on this web page but other releases with the same version number (x.y) should not be displayed.

jpradocueva commented 2 years ago

@rubystream Enablers that are marked as Historic should be displayed with the "Historic" word next to the Version + Date

See an example in the current table (without date)

image
jpradocueva commented 2 years ago

@jmudge please check, I believe that the problem has been rectified with the latest changes. Thanks

jmudge commented 2 years ago

@jpradocueva most of the occurences have now been resolved. There is the observation that for OMA Presence Simple both the "V1.0.1 Historic" and "V1.0" releases are listed. "V1.0" should not be displayed here, however this is relatively minor.

jpradocueva commented 2 years ago

@rubystream it seems that the logic of displaying the latest release is not working well when the Enabler is declared Historic

In this screenshot, you can see that the Enabler was declared Historic in release v1.0.1 but the system still displays v1.0. In this case version, v1.0 has been superseded by version V1.0.1, which at the same time is historic. Please add here the commit that resolves this issue. I would like to see what code needs to be changed. Thanks!

image
rubystream commented 2 years ago

Resolved in 5e0ff40a4f52834d4bd439770bdd6099a74b0cd3

jpradocueva commented 2 years ago

@jmudge Dejan has updated the logic and the issue was resolved. Could you please check if there is any other problem? Thanks

jpradocueva commented 2 years ago

@rubystream something when wrong with this commit https://github.com/OpenMobileAlliance/technical.openmobilealliance.org/commit/5e0ff40a4f52834d4bd439770bdd6099a74b0cd3 all the latest versions are not longer displayed. For instance, LwM2M only displays v1.2, but it should display v1.0.2 and v1.1.1

rubystream commented 2 years ago

@jpradocueva can you take a look now at version 1cc890d722eca446c9fe34b0103a6557bc18307d

jpradocueva commented 2 years ago

@rubystream The problem has been resolved. Thanks