OpenModelica / OpenModelica

OpenModelica is an open-source Modelica-based modeling and simulation environment intended for industrial and academic usage.
https://openmodelica.org
Other
820 stars 305 forks source link

Thermocycle library #8522

Open Shalom6624 opened 2 years ago

Shalom6624 commented 2 years ago

Please I am new to openmodelica. Can the thermocycle library (an opensource library) also be used in openmodelica?

casella commented 2 years ago

Why not? It may need some small fixes, and/or openmodelica may need some bugfixes as well.

@jowr, @squoilin, did you ever try Thermocycle with OpenModelica? We can add it to our testsuite and see what happens.

Shalom6624 commented 2 years ago

Why not? It may need some small fixes, and/or openmodelica may need some bugfixes as well.

@jowr, @squoilin, did you ever try Thermocycle with OpenModelica? We can add it to our testsuite and see what happens.

Great! Please I would love if I could be assisted with this as I am seriously needing to do a simulation that requires the thermocycle library.

squoilin commented 2 years ago

Some small models were successfully tested with externalmedia + coolprop some years ago, but all the complex models did not work and would require individual troubleshooting to operate in OM. Unfortunately, we do not have the resources to go through this at the moment, but any help is welcome!

casella commented 2 years ago

@squoilin, we are now reviewing and updating externalmedia+coolprop together with @jowr to get it to work without compromises in omc. Once that is done, we can tentatively add both libraries to the omc testsuite and see what happens. If there are changes need in your library because of the use of some non-standard Modelica code that Dymola accepts, we can open PRs for that, everything else is on our side.

The only requirements are:

Would that work?

casella commented 2 years ago

Update: new versions of ExternalMedia on the way, see modelica-3rdparty/ExternalMedia#62 and modelica-3rdparty/ExternalMedia#55.