search

OpenNMT / CTranslate

Lightweight C++ translator for OpenNMT Torch models (deprecated)
https://opennmt.net/
MIT License
79 stars 50 forks source link

Windows 32-bit build fails (TH) #47

Closed jhnwnd closed 5 years ago

jhnwnd commented 5 years ago

Specifically, compilation of THDiskFile.c fails because int32_t type is undefined. Resolution would be to remove the #ifdef _WIN64 from the include of <stdint.h> at the top of the file. This header defines int32_t for standard C, so no ifdef is needed. This was fixed in the main Torch7 repo. And what do you think of updating TH to the latest of the Torch7 repo or better yet to the actively developed C++ version in ATen? Thanks!

guillaumekln commented 5 years ago

The TH dependency is only there to read a serialized Torch model file, so there is little benefits to update if it works. If you care about Windows 32-bit, please send a PR that just fixes this specific issue.