OpenNewsLabs / autoEdit_2

Fast text based video editing, node Electron Os X desktop app, with Backbone front end.
https://opennewslabs.github.io/autoEdit_2/
MIT License
418 stars 56 forks source link

Tweet that clip #88

Open pietrop opened 5 years ago

pietrop commented 5 years ago

PR for new feature https://github.com/OpenNewsLabs/autoEdit_2/issues/74

To test before merge

Also check

Tweeting video does not seem to work

To do:

pietrop commented 5 years ago

Does not seem to apply as the button is disabled until the tweet has confirmed to have gone through

pietrop commented 5 years ago

Tested and seems to work fine

Tested after latest change that makes captions optional.

Some things to think about

To tweet clips to twitter, twitter credentials are required. And in the current setup the user needs to create a twitter app, in quickQuoteNode which used express, user could just log in with their twitter account using passport.js

The problem is that the app to tweet on user's behalf requires

  1. Twitter Consumer Key
  2. Twitter Consumer Secret
  3. Twitter Access Token
  4. Twitter Access Token Secret

As far as I understood it, the first two, are part of creating a twitter app, with twitter authentication, while the second two are user specific, and the once that where taken through passportJS in quickQuoteNode express example mentioned above.

Using set in and /set out might not be as straight forward as it could be. Eg it could be connected with selections / highlight instead?

Screen Shot 2019-03-27 at 22 21 37

Some stuff left to do

pietrop commented 4 years ago

Leaving a note that with Firebase auth, firebase.auth.TwitterAuthProvider you can do this and get token and secret

// Using a redirect.
firebase.auth().getRedirectResult().then(function(result) {
  if (result.credential) {
    // For accessing the Twitter API.
    var token = result.credential.accessToken;
    var secret = result.credential.secret;
  }
  var user = result.user;
});

// Start a sign in process for an unauthenticated user.
var provider = new firebase.auth.TwitterAuthProvider();
firebase.auth().signInWithRedirect(provider);
pietrop commented 4 years ago

There is also this module

oauth-electron-twitter