Closed shreyp135 closed 3 months ago
Hi @shreyp135 can you please add the google-cloud-storage and aioboto3 packages to jb-lib's pyproject.toml file and update the respective poetry.lock as well?
Thanks @KaranrajM for reviewing the pull request. I have made the necessary changes.
Hi @shreyp135 the changes look good. I hope all the test cases are passing and the cloud connectors were tested with keys and all the functions are working.
Hi @shreyp135 can you make sure the test cases are passing. It threw aioboto3 does not have client error and aioboto3 package has only session and client is absent. So we have to access client via session only from aioboto3. So can you make these changes. Also please change google-cloud package in pyproject.toml to google-cloud-storage.
Since this PR was merged, can you push these new changes to a new branch and create a new PR that we can merge it with main when you make these changes? @shreyp135
Hello @shreyp135 , Thanks for your contribution. As part of Augtoberfest, we want to reward you for your contributions, so pls fill out this form by 19th Sept. Thanks.
172
Added cloud storage connectors(sync and async) for aws and gcp. Added tests for aws and gcp. Added required env variables in the env template file.