OpenOrbis / mira-project-archive

The Homebrew Platform
GNU General Public License v3.0
221 stars 50 forks source link

overlayFS #71

Closed Zer0xFF closed 6 years ago

Zer0xFF commented 6 years ago

Just want to comment on ece9ce9, I spoke to @theorywrong and he also commented about removing that unmount block all together, and I'm more than happy to recommit that code to do so, if that was the final consensus.

finally, overlayfs.c Line 260, for most of my test I unmount the mod directory when ./dev is deleted, as it's a good indiction the game is getting unmounted, however, I also want to test how the code behaves if left unchanged (but due to time shortage I haven't yet, it seemed to have fixed my initial kpanics, and due to lack of time I stuck with it none the less, however, I avoided committing the code for a potentially unnecessary change, but its something to keep an eye on (I will however test it once I get the chance to do so))

Cryptogenic commented 6 years ago

Changes look good, tester has confirmed it doesn't cause any issues on the system - I'm going to merge this :)