search

OpenPrinting / libcupsfilters

Apache License 2.0
7 stars 26 forks source link

Update doc->orientation value in imagetopdf.c file #17

Closed sourabh1952 closed 1 year ago

sourabh1952 commented 1 year ago

value of doc->orientation not set when landscape mode is true. Due to this the final output have portrait orientation always no matter if the value of landscape is true. @tillkamppeter sir can you please review it. Thank you.

tillkamppeter commented 1 year ago

Unfortunately, the problem was not that simple, but rather complex. It seems that the original CUPS filters from which the cfFilterImageTo...() filter functions are derived were even not 100% correct. I have fixed everything in commit 7a538c7b5c (click the link and see the commit message).

But thank you anyway, @sourabh1952 , this was really too much for an assignment ...