search

OpenPrinting / system-config-printer

Graphical user interface for CUPS administration
GNU General Public License v2.0
160 stars 88 forks source link

make probe_printer a little bit better #127

Closed GreatBahram closed 5 years ago

GreatBahram commented 5 years ago

Hi, Thanks for this project, I need some part of your code and I've changed them to be readable. I didn't know what's your plan about future? do you want to still support Python2? on my project I'll change the code to be compatible with Python3.

Thanks

zdohnal commented 5 years ago

Hi, as far as I know system-config-printer was migrated to Python3. Would you mind elaborate on the thought 'still supporting Python2'? You probably think the code style, if I understand correctly?

If it is code style what you meant, then: 1) if the code works in python3, then it is not pressing matter to change it - there are more pressing matters to fix/enhance on the project (like IPP2.0 enablement or IPP everywhere support) 2) if I would agree to change the code style, then it has to be done in whole project, not in one file. If you want to do it, you are welcome to send the patch.

If the issue is not about code style, please let me know and we can work it out.

For the pull request, I'll close it for now, because it changes only code style and only for one file.

Thank you in advance and thank you for the patch!

Zdenek

GreatBahram commented 5 years ago

I'm not sure about changing the whole project, I don't think so. I just need some parts that works with network protocols like ipp and other stuff and maybe some programs that work with ppd files. Anyway, about the problems that I mentioned, I'll open an issue for them. My pleasure and thank you and all other people who worked on this project