OpenPrinting / system-config-printer

Graphical user interface for CUPS administration
GNU General Public License v2.0
160 stars 88 forks source link

Localization guide: Source string location #150

Closed Jibec closed 4 years ago

Jibec commented 4 years ago

In gettext, the source string location is relative to the place the script to execute the pot was generated.

a source string location could contain "../" and thus, impact the URL.

As an example: https://github.com/OpenPrinting/system-config-printer/blob/master/../asyncipp.py#L474 will become https://github.com/OpenPrinting/system-config-printer/blob/asyncipp.py#L474 and lead to a 404 error page.

I would expect: a line in Localization guide that checks if context works as expected. A warning sign in case of error. An email in case of error detection.

When trigger this check? Each time weblate repo is updated. What to check: three values (first, middle, last) Results is a warning if one of the URL failed

thanks a lot for your help

zdohnal commented 4 years ago

Hi @Jibec ,

I'm not quite sure what to take of the issue - it seems like a report for weblate, not system-config-printer.

Jibec commented 4 years ago

Oh, true, sorry about that! You can close it.

zdohnal commented 4 years ago

Np, thank you for letting me know!